Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: third party app support in EVADB #1033

Merged

Conversation

kaushikravichandran
Copy link
Collaborator

This PR introduces a generic interface to support 3rd party apps in EVADB. As an example. the template for integrating slack has been added. In a subsequent PR the integration with slack will be completed.

@kaushikravichandran kaushikravichandran marked this pull request as ready for review September 2, 2023 18:19
@jiashenC
Copy link
Member

jiashenC commented Sep 2, 2023

I'd like to understand the context of this PR better. We discussed the Slack chatbot use case yesterday, and I believe that it can be a standalone app without changing EvaDB internally or adding third-party integrations.

Is this PR going to facilitate some other new use cases? If so, could you give some detailed examples here and also explain a bit about how it will interact with EvaDB?

Thank you!

Kaushik Ravichandran added 2 commits September 17, 2023 14:43
@jarulraj
Copy link
Member

That's a big PR, @kaushikravichandran! Nice job, let's wrap it up.

@xzdandy xzdandy added Data Sources Features/Bugs related to Data Sources and removed Feature Request ✨ New feature or request labels Sep 22, 2023
@xzdandy xzdandy added this to the v0.3.7 milestone Sep 22, 2023
@jarulraj
Copy link
Member

If it is good to merge, let's do that. Students working on application integrations will require the handler inferface.

@xzdandy xzdandy self-assigned this Sep 26, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented Sep 26, 2023

I will take care of the PR.

@kaushikravichandran
Copy link
Collaborator Author

I will take care of the PR.

Thanks. I have resolved the latest set of conflicts now.

@jarulraj
Copy link
Member

@kaushikravichandran Please add docs for the app handler interface soon as students will need it.

@gaurav274 gaurav274 mentioned this pull request Sep 30, 2023
7 tasks
@xzdandy xzdandy removed this from the v0.3.7 milestone Sep 30, 2023
@jarulraj
Copy link
Member

Any reason the unfortunately repeated conflict merging on this PR. @xzdandy @kaushikravichandran

@jarulraj
Copy link
Member

jarulraj commented Nov 2, 2023

@kaushikravichandran is reducing the size of this PR.

@jarulraj jarulraj merged commit bd344ed into georgia-tech-db:staging Nov 6, 2023
7 checks passed
@xzdandy xzdandy added this to the v0.3.9 milestone Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Sources Features/Bugs related to Data Sources Integrations 🧩 Pull requests that update an integration
Projects
Development

Successfully merging this pull request may close these issues.

5 participants