Adding clickhouse as a datasource #1072
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hello @Preethi1609, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify that your PR is up-to-date with
georgia-tech-db/evamasterbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.
| @@ -200,6 +200,24 @@ def test_should_run_query_in_mysql(self): | |||
| # Test executions. | |||
| self._execute_native_query() | |||
| self._execute_evadb_query() | |||
|
|
|||
| def test_should_run_query_in_clickhouse(self): | |||
There was a problem hiding this comment.
Does the test needs a clickhouse backend?
There was a problem hiding this comment.
Yes I will work on it in the upcoming week!
There was a problem hiding this comment.
@Preethi1609 How do you plan to setup clickhouse?
@xzdandy @jiashenC Should we add it to CircleCI via docker?
https://hub.docker.com/r/clickhouse/clickhouse-server/
There was a problem hiding this comment.
Yes we could have a clickhouse server running on 9000?
There was a problem hiding this comment.
I don't think CircleCI has a built-in docker image for Clickhouse, so we probably look for some other ways to make it work with Clickhouse.
| @@ -200,6 +200,24 @@ def test_should_run_query_in_mysql(self): | |||
| # Test executions. | |||
| self._execute_native_query() | |||
| self._execute_evadb_query() | |||
|
|
|||
| def test_should_run_query_in_clickhouse(self): | |||
There was a problem hiding this comment.
I don't think CircleCI has a built-in docker image for Clickhouse, so we probably look for some other ways to make it work with Clickhouse.
.circleci/config.yml
Outdated
| resource_class: large | ||
| docker: | ||
| - image: "cimg/python:<< parameters.v >>" | ||
| - image: "cimg/mysql:8.0" |
There was a problem hiding this comment.
This workflow needs to be changed for clickhouse.
No description provided.