-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify line measures #1216
Merged
Merged
Unify line measures #1216
Commits on Sep 25, 2024
-
All of these algorithm implementations already existed, but I'm proposing a new way to organize them which I hope will be more consistent and discoverable. Note: The new Haversine::bearing and Geodesic::bearing return 0..360, the legacy traits HaversineBearing and GeodesicBearing returned -180..180 Additional changes: Deleted the deprecated `Bearing` trait which was previously superceeded by the unambiguous `HaversineBearing` trait, but now is re-defined as `Haversine::bearing` = Future Work = In an effort to minimize this PR, while keeping the change reasonably coherent, I've left some things out == Methods on Euclidean == -[ ] bearing (doesn't currently exist) -[ ] destination (doesn't currently exist) -[ ] intermediate (exists, but InterpolatePoint trait also needs intermediate_fill) -[ ] intermediate_fill (doesn't currently exist) == Deprecate Legacy Traits == -[ ] Deprecate Legacy impls -[ ] Switcheroo the actual implementation: move the actual implementation to the new traits, and have the legacy traits delegate to the new traits. -[ ] Move over any tests from the legacy implementation to the new home == Methods on Geoms (Future PR) == -[ ] Length -[ ] Haversine -[ ] Rhumb -[ ] Geodesic -[ ] Euclidean -[ ] Densify -[ ] Haversine -[ ] Rhumb -[ ] Geodesic -[ ] Euclidean FIXES #1210 FIXES #1181
Configuration menu - View commit details
-
Copy full SHA for c54af80 - Browse repository at this point
Copy the full SHA c54af80View commit details -
bump MSRV to 1.75 to support "return-position impl Trait in trait"
This is needed for the "Unify line measures" work.
Configuration menu - View commit details
-
Copy full SHA for 0f184d1 - Browse repository at this point
Copy the full SHA 0f184d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ae5890 - Browse repository at this point
Copy the full SHA 5ae5890View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8446610 - Browse repository at this point
Copy the full SHA 8446610View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ecd4d3 - Browse repository at this point
Copy the full SHA 6ecd4d3View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e28647e - Browse repository at this point
Copy the full SHA e28647eView commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 01eb36c - Browse repository at this point
Copy the full SHA 01eb36cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61783e1 - Browse repository at this point
Copy the full SHA 61783e1View commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 032b94d - Browse repository at this point
Copy the full SHA 032b94dView commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0b8c444 - Browse repository at this point
Copy the full SHA 0b8c444View commit details -
fixup: impl Interpolate for CoordFloat, not just f64
This was a copy/paste error from the impl on Geodesic which truly does only support f64 - for Haversine and Rhumb though, we can support any CoordFloat+FromPrimitive
Configuration menu - View commit details
-
Copy full SHA for 58d4e28 - Browse repository at this point
Copy the full SHA 58d4e28View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.