-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a bug in rstar 0.12.1, so pin for now. #1261
Conversation
Let's hold off until Adam has a look at georust/rstar#181 – #1254 is open to enable #1246, but #1246 depends on a new API in rstar 0.12.1 so would be blocked by this anyway. |
I'm ok to wait for a little bit, but my primary concern isn't the new feature in #1246, but rather on |
It looks like resolution is imminent with georust/rstar#184 Anyone opposed to my following up with patch releases to geo-types and geo to require |
Do we need to do that if we yank rstar 0.12.1? |
0.12.1 is yanked |
I'm not sure! What happens if you run |
Answering my own question: Unless we make a new release, the user would need to either run (unqualified) Proof:
|
Annoying. Thanks for figuring that out! |
Where did we land on this after yesterday's discussion? My understanding is that there was a 24 hour (ish) period during which, if you updated your |
I think Cargo givea a warning if you have a yanked crate in your lockfile. Should be relatively easy to test. |
CHANGES.md
if knowledge of this change could be valuable to users.FIXES #1260
see: georust/rstar#181
We don't have to do this - we could wait a bit if we think an rstar fix is forthcoming.