Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug-level printout for CAP.EXTDATA to show container name being read from ExtData.rc #31

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Add debug-level printout for CAP.EXTDATA to show container name being read from ExtData.rc #31

merged 3 commits into from
Feb 15, 2024

Conversation

yantosca
Copy link

@yantosca yantosca commented Jan 11, 2024 •
edited by lizziel
Loading

Description

This PR adds a debug logger call to print out the name of the data container being read from ExtData.rc.

Related Issue

closes #30

Motivation and Context

Currently, MAPL does not include this information in when setting the CAP.EXTDATA settings to DEBUG mode. This can make it difficult to diagnose and find issues caused by improperly-formatted netCDF files.

How Has This Been Tested?

I have tested this with a GCHP simulation with CAP.EXTDATA options set to DEBUG in logging.yml. This is the output:

0000: CAP.EXTDATA: DEBUG: Reading this data container: ALBD
0001: CAP.EXTDATA: DEBUG: Reading this data container: ALBD
0002: CAP.EXTDATA: DEBUG: Reading this data container: ALBD
0003: CAP.EXTDATA: DEBUG: Reading this data container: ALBD
0004: CAP.EXTDATA: DEBUG: Reading this data container: ALBD
0005: CAP.EXTDATA: DEBUG: Reading this data container: ALBD
0000: CAP.EXTDATA: DEBUG: Reading this data container: CLDFRC
0001: CAP.EXTDATA: DEBUG: Reading this data container: CLDFRC
0002: CAP.EXTDATA: DEBUG: Reading this data container: CLDFRC
0003: CAP.EXTDATA: DEBUG: Reading this data container: CLDFRC
0004: CAP.EXTDATA: DEBUG: Reading this data container: CLDFRC
0005: CAP.EXTDATA: DEBUG: Reading this data container: CLDFRC
0000: CAP.EXTDATA: DEBUG: Reading this data container: EFLUX
0001: CAP.EXTDATA: DEBUG: Reading this data container: EFLUX
0002: CAP.EXTDATA: DEBUG: Reading this data container: EFLUX
0003: CAP.EXTDATA: DEBUG: Reading this data container: EFLUX
0004: CAP.EXTDATA: DEBUG: Reading this data container: EFLUX
0005: CAP.EXTDATA: DEBUG: Reading this data container: EFLUX
... etc ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@yantosca
Add debug output for the container name being read by ExtData.rc
907ac97 
gridcomps/ExtData/ExtDataGridCompMod.F90
- At line5 555, add a debug logger call to print out the name of the
  container being read by ExtData.rc.  This can help in finding
  netCDF files that are not compatible with GCHP.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Update changelog with info about debug logger call
fe3488e 
CHANGELOG.md
- Updated with a note about adding the debug logger call
  in ExtDataGridCompMod.F90

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Remove leftover debug print statement in ExtDataGridCompMod.F90
7ffd1c7 
gridcomps/ExtData/ExtDataGridCompMod.F90
- Removed a leftover print statement used for debugging

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added the enhancement New feature or request label Jan 11, 2024
@yantosca yantosca requested a review from lizziel January 11, 2024 16:35
@yantosca yantosca changed the title Bugfix/print extdata container being read Add debug-level printout for CAP.EXTDATA to show container name being read from ExtData.rc Jan 11, 2024
lizziel
lizziel approved these changes Jan 11, 2024
View reviewed changes
Copy link

@lizziel lizziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this in!

@yantosca yantosca mentioned this pull request Jan 11, 2024
Closed
@yantosca yantosca merged commit d61f89a into gchp/dev Feb 15, 2024
2 checks passed
@yantosca yantosca mentioned this pull request Feb 16, 2024
Closed
@yantosca yantosca deleted the bugfix/print-extdata-container-being-read branch April 24, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizziel lizziel lizziel approved these changes

Assignees

@lizziel lizziel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need debug printout of the data container being read by ExtData
2 participants
@yantosca @lizziel