Update Is_Photolysis tags in species_database.yml to be consistent with Cloud-J file FJX_j2j.dat
#2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantosca
added
topic: Configuration Files
|
@kelvinhb @ktravis213: Should we remove CF3I and H12O2 from the |
yantosca
force-pushed
the
bugfix/update-is-photolysis-tags-in-spcdb
branch
from
830090b to
a5fba9c
Compare
run/shared/species_database.yml
- Added "Is_Photolysis: true" to the following entries:
APINP, AROMCHO, BPINOOH, BPINP, C96O2H, H2O, HO2, LIMAL,
LIMO2H, LIMO3H, PINAL, PINO3H, PINONIC, SO2
- Removed "Is_Photolysis: true" from the following entries:
APINN, AROMPN, BPINN, BPINON, C96N, CHCl3, HC5A, LIMN,
LIMNB, LIMPAN, MEKPN, MPAN, PHAN, PIN, PINPAN
- Moved PINO3H to be in alphabetical order.
Signed-off-by: Bob Yantosca <[email protected]>
|
Integration tests are running |
run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem - Updated "Jval_" entries to use only the proper photolysis species CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : 9767068 GEOS-Chem submod update: Merge PR #2452 (Reorder photo rxns for PNs, ANs)
MAPL : 231d53c Merge pull request #36 from geoschem/feature/improve_hflux_regridding
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem : 25332d38c Updated J-value entries in GCHP HISTORY.rc.fullchem file
HEMCO : d0d5fca PR #285 post-merge fix: Update CHANGELOG.md
yaFyaml : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J : 6bf4a36 Merge pull request #26 from geoschem/feature/define_max_rather_than_exact_num_jvalues
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Number of execution tests: 12
Submitted as SLURM job: 46681728
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : b577abe GEOS-Chem submod update: Merge PR #2452 (Reorder photo rxns for PNs, ANs)
GEOS-Chem : 25332d38c Updated J-value entries in GCHP HISTORY.rc.fullchem file
HEMCO : d0d5fca PR #285 post-merge fix: Update CHANGELOG.md
Cloud-J : 6bf4a36 Merge pull request #26 from geoschem/feature/define_max_rather_than_exact_num_jvalues
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 30
Submitted as SLURM job: 46681436
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
msulprizio
requested changes
Sep 12, 2024
CHANGELOG.md - Consolidate species that were added in Travis et al 2024 into a single note under "Added" Signed-off-by: Bob Yantosca <[email protected]>
msulprizio
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This is the companion PR to #2456. We have edited the
run/shared/species_database.ymlfile so that species having a photolysis reaction inKPP/fullchem/fullchem.eqnwill be tagged withIs_Photolysis: true.Added
Is_Photolysis: truetags to APINP, AROMCHO, BPINOOH, BPINP, C96O2H, H2O, HO2, LIMAL, LIMO3H, PINAL, PINONIC, SO2 inspecies_database.ymlChanged
species_database.ymlRemoved
Is_Photolysis: truetags from APINN, AROMPN, BPINN, BPINON, C96N, CHCl3, HC5A, LIMN, LIMNB, LIMPAN, MEKPN, MPAN, PHAN, PIN, PINPAN inspecies_database.ymlExpected changes
This should not change the benchmark results. However,
Is_Photolysis: truedetermines which species are included in theJValuescollection when using theJVal_?JVN?wildcard. Therefore, theGEOSChem.JValues*diagnostic files produced by should no longer include species that aren't photolyzed.Related Github Issue
species_database.ymlandFJX_j2j.datfor fullchem mechanism #2456Tagging @msulprizio @lizziel @ktravis213 @kelvinhb