Bug fix: ALK6 in HEMCO_Config.rc should be ALK7 #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the updated monoterpene/PN/AN chemistry and emissions added in 14.5.0-alpha.6 (updates on top of PR #2318), emissions for >=C6 alkanes from CEDS were added to HEMCO_Config.rc. These were incorrectly assigned to species ALK6 (not defined) when they should be assigned to ALK7. Other fixes here include: - Update HEMCO_Diagn.rc (and HISTORY.rc for GCHP) to save out ALK7 emissions - Fix category for CEDS ship emissions of HCOOH and ALK7 in HEMCO_Config.rc (should be 10, not 1) - Make fullchem HEMCO_Diagn.rc for WRF consistent with GCClassic version Closes #2459 Signed-off-by: Melissa Sulprizio <[email protected]>
yantosca
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Looks good to merge! Thanks @msulprizio. I'll start pulling this in and testing.
|
Integration tests are running. |
==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : 5e00d7e GEOS-Chem update: Merge PR #2457 (Update Is_Photolysis tags)
GEOS-Chem : 084a8cf8d Merge PR #2462 (Bug fix: ALK6 in HEMCO_Config.rc should be ALK7)
HEMCO : c6a9d46 Merge PR #287 (Updated Y. Wang soil NOx scheme as an option)
Cloud-J : 6bf4a36 Merge pull request #26 from geoschem/feature/define_max_rather_than_exact_num_jvalues
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 30
Submitted as SLURM job: 46770790
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
|
All GCHP integration tests also passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : 984823f GEOS-Chem update: Merge PR #2457 (Update Is_Photolysis tags)
MAPL : 231d53c Merge pull request #36 from geoschem/feature/improve_hflux_regridding
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem : 084a8cf8d Merge PR #2462 (Bug fix: ALK6 in HEMCO_Config.rc should be ALK7)
HEMCO : c6a9d46 Merge PR #287 (Updated Y. Wang soil NOx scheme as an option)
yaFyaml : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J : 6bf4a36 Merge pull request #26 from geoschem/feature/define_max_rather_than_exact_num_jvalues
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Number of execution tests: 12
Submitted as SLURM job: 46770957
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard
Describe the update
With the updated monoterpene/PN/AN chemistry and emissions added in 14.5.0-alpha.6 (updates on top of PR #2318), emissions for >=C6 alkanes from CEDS were added to HEMCO_Config.rc. These were incorrectly assigned to species ALK6 (not defined) when they should be assigned to ALK7.
Other fixes here include:
Please provide a clear and concise overview of the update.
Expected changes
This will increase ALK7 (a new species in 14.5.0) by including its emissions.
Related Github Issue
Closes #2459