Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue creating Circle annotation with form radius #10829

Open
1 task done
tdipisa opened this issue Feb 20, 2025 · 1 comment · May be fixed by #10845
Open
1 task done

Issue creating Circle annotation with form radius #10829

tdipisa opened this issue Feb 20, 2025 · 1 comment · May be fixed by #10845
Assignees
@dsuren1
Labels
annotations related to the annotation tool BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch bug Regression
Milestone
2025.01.00

Comments

@tdipisa
Copy link
Member

tdipisa commented Feb 20, 2025 •
edited
Loading

Description

There is a wrong behavior using the circle geometry in the annotations tool for which the you cannot create a new circle with the desired radius and coordinates if not drawing the circle before on map.

How to reproduce

  • Click on the circle geometry
  • Add a radius value
  • Click on the map to add the circle

Expected Result

Normally the circle is drawn with the radius value indicated in the form.

Image

Current Result

  • Unfortunately, you have to draw the circle and then change the radius value

  • Not browser related

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

This is a regression from v2024.01.00. The fix need to be backported to 2024.02.xx.
@tdipisa tdipisa added this to the 2025.01.00 milestone Feb 20, 2025
@tdipisa tdipisa added annotations related to the annotation tool BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch estimate needed labels Feb 20, 2025
@tdipisa tdipisa mentioned this issue Feb 20, 2025
Open
@dsuren1
Copy link
Contributor

dsuren1 commented Feb 21, 2025 •
edited
Loading

Investigation Outcome

  • The feature was inadvertently omitted when the Annotation UI was revamped and needs to implemented.
  • During the preliminary investigation, a stale closure issue appears to occur when the drawing process ends, leading to an incorrect value being captured and causing the form value to reset. This issue seems to affect annotations with fields other than coordinates (e.g., text in Text annotations and radius in Circle annotations). Needs to be fixed during implementation

dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Feb 24, 2025
@dsuren1
geosolutions-it#10829: Fix - Issue creating Circle annotation with fo…
23979a6 
…rm radius
@dsuren1 dsuren1 linked a pull request Feb 24, 2025 that will close this issue
Open
6 tasks
@dsuren1 dsuren1 linked a pull request Feb 24, 2025 that will close this issue
#10829: Fix - Issue creating Circle annotation with form radius #10845
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuren1 dsuren1

Labels
annotations related to the annotation tool BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch bug Regression
Projects
None yet
Milestone
2025.01.00
Development

Successfully merging a pull request may close this issue.

#10829: Fix - Issue creating Circle annotation with form radius dsuren1/MapStore2
2 participants
@tdipisa @dsuren1