Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10829: Fix - Issue creating Circle annotation with form radius #10845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Feb 24, 2025

Description

This PR allows user to create circle with radius predefined by clicking on map from circle annotation type

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?

  • The annotation circle can be drawn with radius predefined and clicking on the map to places the circle.
  • Fixes an issue where a stale closure caused outdated feature properties to be used when annotations contained fields other than coordinates (e.g., text in Text annotations or radius in Circle annotations) during updates at the end of drawing.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added bug annotations related to the annotation tool BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch Regression labels Feb 24, 2025
@dsuren1 dsuren1 added this to the 2025.01.00 milestone Feb 24, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap February 24, 2025 13:22
@dsuren1 dsuren1 self-assigned this Feb 24, 2025
@dsuren1 dsuren1 linked an issue Feb 24, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotations related to the annotation tool BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch bug Regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue creating Circle annotation with form radius
1 participant