Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StyleEditor plugin must not rely on the workspace prefix inside the style names returned by GetCapabilities #7422

Closed
1 task done
allyoucanmap opened this issue Oct 7, 2021 · 0 comments
Closed
1 task done

StyleEditor plugin must not rely on the workspace prefix inside the style names returned by GetCapabilities #7422

allyoucanmap opened this issue Oct 7, 2021 · 0 comments
Assignees
@tdipisa @allyoucanmap @ElenaGallo
Labels
Accepted bug Priority: Blocker
Milestone
2021.02.00

Comments

@allyoucanmap
Copy link
Contributor

Description

Geoserver 2.19.x fixed a wrong behaviour where style names isnide workspace-specific GetCapabilities reponse were returned with the workspace prefix.
MapStores Styled editor relied on this prefix for its functionalities, which now are broken with Geoserver 2.19.x.
...

see GeoNode/geonode-mapstore-client#519

How to reproduce

  • login as admin (eg #/viewer/openlayers/10358)
  • open a map and add a wms layer from catalog with style editing permissions (eg States of US)
  • select the wms layer and open settings
  • select the style tab

Expected Result

  • all the styles should be available for edit or delete action

Current Result

  • style included in a specific workspace cannot be edited or deleted because mapstore is not able to build the correct url due to latest fix

  • Not browser related

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@allyoucanmap allyoucanmap added this to the 2021.02.00 milestone Oct 7, 2021
@allyoucanmap allyoucanmap self-assigned this Oct 7, 2021
This was referenced Oct 7, 2021
Closed
Closed
@allyoucanmap allyoucanmap mentioned this issue Oct 7, 2021
Merged
5 tasks
tdipisa pushed a commit that referenced this issue Oct 12, 2021
@allyoucanmap
#7422: StyleEditor plugin must not rely on the workspace prefix insid…
e980e77 
…e the style names returned by GetCapabilities (#7423)

* replace get capabilities request with GeoServer rest api to get information about styles

* get missing styles information from get capabilities

* store the current default style name

* remove restriction on workspace for editing
@tdipisa tdipisa self-assigned this Oct 12, 2021
@ElenaGallo ElenaGallo self-assigned this Oct 14, 2021
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Oct 14, 2021
@allyoucanmap
geosolutions-it#7422: StyleEditor plugin must not rely on the workspa…
2e14c5e 
…ce prefix inside the style names returned by GetCapabilities (geosolutions-it#7423)

* replace get capabilities request with GeoServer rest api to get information about styles

* get missing styles information from get capabilities

* store the current default style name

* remove restriction on workspace for editing
@allyoucanmap allyoucanmap mentioned this issue Oct 14, 2021
Merged
5 tasks
tdipisa pushed a commit that referenced this issue Oct 14, 2021
@allyoucanmap
#7422: StyleEditor plugin must not rely on the workspace prefix insid…
d72f4bb 
…e the style names returned by GetCapabilities (#7423) (#7447)

* replace get capabilities request with GeoServer rest api to get information about styles

* get missing styles information from get capabilities

* store the current default style name

* remove restriction on workspace for editing
allyoucanmap added a commit that referenced this issue Oct 14, 2021
@allyoucanmap
#7422: StyleEditor plugin must not rely on the workspace prefix insi…
743a5db 
…de the style names returned by GetCapabilities (#7423)

* replace get capabilities request with GeoServer rest api to get information about styles

* get missing styles information from get capabilities

* store the current default style name

* remove restriction on workspace for editing
@giohappy giohappy mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdipisa tdipisa

@allyoucanmap allyoucanmap

@ElenaGallo ElenaGallo

Labels
Accepted bug Priority: Blocker
Projects
None yet
Milestone
2021.02.00
Development

No branches or pull requests
3 participants
@tdipisa @allyoucanmap @ElenaGallo