dashboardSave should use floppy-disk #10644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To distinguish it from 'dashboardSaveAs', 'dashboardSave' should have floppy-disk glyph and 'dashboardSaveAs' has floppy-open
This is analogous to save and saveAs for maps.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior?
both dashboardSave and dashboardSaveAs have floppy-open glyph
What is the new behavior?
'dashboardSave' has floppy-disk and 'dashboardSaveAs' has floppy-open glyphs.
This is just like for maps where 'save' has floppy-disk and 'saveAs' has floppy-open glyphs
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)