Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authkey is currently not sent for WMS GetLegendGraphic requests #10727 #10765

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

rowheat02
Copy link
Contributor

@rowheat02 rowheat02 commented Jan 20, 2025

Description

Auth Token also sent if auth rule matches in SecureImage

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

Issue

#10727

What is the current behavior?
#10727

What is the new behavior?
Auth token is sent to the securedImage URL as params if rule exists in localConfig so legend images are rendered without error.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 self-assigned this Jan 27, 2025
@rowheat02 rowheat02 linked an issue Jan 27, 2025 that may be closed by this pull request
1 task
@rowheat02 rowheat02 added this to the 2025.01.00 milestone Jan 27, 2025
@rowheat02 rowheat02 marked this pull request as ready for review January 27, 2025 08:55
@tdipisa tdipisa requested a review from MV88 January 27, 2025 09:03
Copy link
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rowheat02 please update this PR by aligning it to master branch.

@rowheat02 rowheat02 requested a review from tdipisa January 27, 2025 10:36
@tdipisa tdipisa removed their request for review January 27, 2025 11:23
@tdipisa tdipisa requested review from tdipisa and removed request for tdipisa January 27, 2025 17:20
@MV88 MV88 merged commit fc230b6 into geosolutions-it:master Jan 27, 2025
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Jan 27, 2025

@ElenaGallo testable in DEV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authkey is currently not sent for WMS GetLegendGraphic requests
3 participants