Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options.params to queryParameters so it gets built into the url #10846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tha-nordiq
Copy link
Contributor

Description

layer.params are ignored for wmts layers. A specific wmts provider requires 'username'- and 'password'-url parameters.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
layer.params are ignored.

What is the new behavior?
layer.params are built into the urls

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa
Copy link
Member

tdipisa commented Feb 24, 2025

Dear @tha-nordiq thank you so much for contributing to MS. We will review this PR as soon as possible.

@tha-nordiq
Copy link
Contributor Author

i hadnt seen the test, and i didnt know what addAuthenticationParameter did. Should i modify the code so the test can succeed, and add a new test which includes parameters ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants