Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10807 load map error and correctly update view when sharing a map #10847

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Feb 24, 2025

Description

There were some cases where center was not updated from the changeMapView action and this was because the isNearlyEqual Function was wrongly working with negative values when a values was lesser than the b value, this was causing false positives

this was caused by 842b59b

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #10807

What is the new behavior?

it loads correctly the view from query params center and no error is triggered

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added this to the 2025.01.00 milestone Feb 24, 2025
@MV88 MV88 requested a review from allyoucanmap February 24, 2025 20:12
@MV88 MV88 self-assigned this Feb 24, 2025
@MV88 MV88 changed the title Fix #10835 load map error and correctly update view when sharing a map Fix #10835 #10807 load map error and correctly update view when sharing a map Feb 24, 2025
@tdipisa tdipisa changed the title Fix #10835 #10807 load map error and correctly update view when sharing a map Fix #10807 load map error and correctly update view when sharing a map Feb 25, 2025
@tdipisa tdipisa added the bug label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing map with marker will not record the correct map center
2 participants