improve logging and default handling #8
Merged
+19
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ldanilek would you mind sanity checking my logic here? |
ldanilek
approved these changes
Feb 5, 2025
| if (args.cursor === "" || args.cursor === undefined) { | ||
| if (args.dryRun) { | ||
|
|
||
| const numItems = args.batchSize || defaultBatchSize; |
There was a problem hiding this comment.
i think batchSize=0 still becomes defaultBatchSize. is that intentional?
There was a problem hiding this comment.
It's not necessary, but is also ok here. I believe this is only possible when calling from the dashboard / CLI and that value is likely only ever 0 if it's set as a "helpful" default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only print help when it's being called directly from the CLI /dashboard, without modifying other flows.
When it's called from the component,
cursoris a string or null,dryRunis always a boolean.From the CLI / dashboard, they won't be set by default (though the dashboard used to set defaults like
cursor: ""andbatchSize: 0so we also check for that in case it comes back).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.