Add handling for CLOUD_SERVICES service_type #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
ian-whitestone
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
ian-whitestone
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
NiallRees
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces the
service_typeto be one of the two fields we expect:COMPUTEorSTORAGEI missed this in #141. Here's the new values we are seeing:
And an example of what we see in our main Snowflake account (and what I've seen in every other account):