Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge order-matching fee for limit orders #910

Closed
Tracked by #972
luckysori opened this issue Jul 5, 2023 · 7 comments
Closed
Tracked by #972

Charge order-matching fee for limit orders #910

luckysori opened this issue Jul 5, 2023 · 7 comments
Milestone

Comments

@luckysori
Copy link
Contributor

luckysori commented Jul 5, 2023

In #838 we mentioned an order-matching fee for the maker. PR #863 only dealt with the app side.

The example value suggested for the maker was 0.15%, half of the taker's.

For now only the maker binary should be able to create limit orders, which is why this topic is also known as the "order-matching fee for the maker".

@bonomat bonomat added this to the 1.2.0 milestone Jul 10, 2023
@bonomat bonomat mentioned this issue Jul 21, 2023
@da-kami
Copy link
Contributor

da-kami commented Jul 28, 2023

For me this means that the coordinator will have to distinguish how much to charge each party involved in the trade.
I suppose the decision can be based on the order type - if it is a limit order the fee will be different than if it is a market order.

I would avoid talking about maker and taker if it can be avoided and rather just use e.g. the order type as criteria which implies maker and taker.

@bonomat
Copy link
Contributor

bonomat commented Jul 30, 2023

Yes, the maker will need a channel with the coordinator to pay this fee.

@bonomat bonomat removed the grooming label Jul 30, 2023
@bonomat
Copy link
Contributor

bonomat commented Jul 30, 2023

depends on #926

@bonomat bonomat added the maker label Jul 30, 2023
@luckysori luckysori changed the title Charge order-matching fee to maker Charge order-matching fee for limit orders Jul 31, 2023
@bonomat bonomat modified the milestones: 1.3.0, 1.3.1 Aug 14, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
@luckysori luckysori removed the Stale label Sep 19, 2023
@luckysori
Copy link
Contributor Author

I think we still want this eventually.

@luckysori luckysori reopened this Sep 19, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 20, 2023
@bonomat bonomat removed the Stale label Oct 22, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants