Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add channel capabilities to the maker #926

Closed
Tracked by #972
bonomat opened this issue Jul 7, 2023 · 2 comments · Fixed by #1117
Closed
Tracked by #972

Add channel capabilities to the maker #926

bonomat opened this issue Jul 7, 2023 · 2 comments · Fixed by #1117
Assignees
@luckysori
Labels
maker
Milestone
1.3.0

Comments

@bonomat
Copy link
Contributor

bonomat commented Jul 7, 2023

The PR #785 removed the channel capabilities from the maker.

This was useful because we could test another service opening channels with the coordinator besides LND.

We will also need this in the long run.
@bonomat bonomat mentioned this issue Jul 21, 2023
Closed
@holzeis holzeis added this to the 1.2.0 milestone Jul 21, 2023
@holzeis holzeis changed the title Make maker work again Add channel capabilities to the maker Jul 21, 2023
@da-kami
Copy link
Contributor

da-kami commented Jul 28, 2023 •
edited
Loading

I assume that we want to charge fees, as mentioned in #910, so I think this ticket will be a necessity for #972, because otherwise the maker will not be able to pay fees.
Just pointing this out because the description reads like the ticket might not be mandatory.

@bonomat
Copy link
Contributor Author

bonomat commented Jul 30, 2023

Note: for the time being we don't have DLCs in this channel, which means, a single sided channel is not a problem. However, ideally we can think about how we can achieve a dual-funded channel with this.
JIT might not be ideal because I assume the channel size between maker and coordinator will be quite big and this will un-balance the coordinator's in-bound liquidity enormously.

@bonomat bonomat added the maker label Jul 30, 2023
This was referenced Jul 30, 2023
Closed
Closed
@luckysori luckysori mentioned this issue Jul 31, 2023
Closed
@luckysori luckysori self-assigned this Aug 14, 2023
luckysori added a commit that referenced this issue Aug 18, 2023
@luckysori
feat: Add Lightning-node capabilities to the maker
473b6d8 
Fixes #926.

The main goal of this patch is to give the maker the ability to open a
channel with the coordinator to make direct payments. These will
firstly be used to pay order-matching fees. Eventually they will also
be used to set up DLC channels corresponding to trades.
@luckysori luckysori mentioned this issue Aug 18, 2023
Merged
luckysori added a commit that referenced this issue Aug 18, 2023
@luckysori
feat: Add Lightning-node capabilities to the maker
3fdd820 
Fixes #926.

The main goal of this patch is to give the maker the ability to open a
channel with the coordinator to make direct payments. These will
firstly be used to pay order-matching fees. Eventually they will also
be used to set up DLC channels corresponding to trades.
luckysori added a commit that referenced this issue Aug 18, 2023
@luckysori
feat: Add Lightning-node capabilities to the maker
d346043 
Fixes #926.

The main goal of this patch is to give the maker the ability to open a
channel with the coordinator to make direct payments. These will
firstly be used to pay order-matching fees. Eventually they will also
be used to set up DLC channels corresponding to trades.
luckysori added a commit that referenced this issue Aug 18, 2023
@luckysori
feat: Add Lightning-node capabilities to the maker
260eff2 
Fixes #926.

The main goal of this patch is to give the maker the ability to open a
channel with the coordinator to make direct payments. These will
firstly be used to pay order-matching fees. Eventually they will also
be used to set up DLC channels corresponding to trades.
luckysori added a commit that referenced this issue Aug 18, 2023
@luckysori
feat: Add Lightning-node capabilities to the maker
c136a64 
Fixes #926.

The main goal of this patch is to give the maker the ability to open a
channel with the coordinator to make direct payments. These will
firstly be used to pay order-matching fees. Eventually they will also
be used to set up DLC channels corresponding to trades.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luckysori luckysori

Labels
maker
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Add Lightning-node capabilities to the maker get10101/10101
4 participants
@bonomat @holzeis @da-kami @luckysori