Add Lightning-node capabilities to the maker #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckysori
force-pushed
the
maker-channel
branch
from
473b6d8 to
3fdd820
Compare
Fixes #1087. We fix two issues here: - We no longer assume that the order-matching fee is constant. It actually depends on the state of the blockchain, which can change as we run the e2e tests (even if run sequentially!). - We wait for the app to confirm the payment before continuing with test assertions. Otherwise these tests can be flaky. The fact that the test needs to know about certain implementation details (e.g. that the order-matching fee is paid via a payment after the JIT channel is open) is not great, but it's pretty hard to know what fee will be charged from within the test before it is actually paid. This test will probably have to change when we address #843.
luckysori
force-pushed
the
maker-channel
branch
from
3fdd820 to
d346043
Compare
Any test that depends on some maker functionality will require this!
luckysori
force-pushed
the
maker-channel
branch
from
d346043 to
260eff2
Compare
Fixes #926. The main goal of this patch is to give the maker the ability to open a channel with the coordinator to make direct payments. These will firstly be used to pay order-matching fees. Eventually they will also be used to set up DLC channels corresponding to trades.
luckysori
force-pushed
the
maker-channel
branch
from
260eff2 to
c136a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #926.
Fixes #1087.