-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify invoice details #1245
Prettify invoice details #1245
Conversation
23930ec
to
0bdd312
Compare
Looks nice, but.. .would it be possible to use this dialog which comes up from the bottom as shown in the design here? |
Definitely should be possible, I can just swap out the container :) |
@bonomat: I've updated the screenshots |
7eddcdd
to
f16e9d5
Compare
I really don't like this solution
f16e9d5
to
32aacb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This took me quite a while and I am still not quite happy with it, but it's good enough 😅
Intrinsic sizes and dialogues in flutter are weird
Looks pretty nice already! 👍 Nit: I don't think we need to copy all rows. e.g. when, expiry, etc. 😅 Also the fonts seem pretty small can you make it bigger? And maybe have the content aligned to the right size with a bit space in between label and content? 😬 |
I think it looks better but I don't love it yet. I'm happy to play around with it if you don't have patience anymore. |
1 similar comment
I think it looks better but I don't love it yet. I'm happy to play around with it if you don't have patience anymore. |
@bonomat: sure, that's okay! If you have a clear vision for how it should look then go ahead :) |
Note to self:
Will try fix these for merge |
65ff23f
to
8daa0ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks for going over it once more.
Fixes #872 by prettifying the invoice details modeled in #1111 and #1213
To do: