Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Open scanner on send button #1694

Merged
merged 1 commit into from
Dec 7, 2023
Merged

feat: Open scanner on send button #1694

merged 1 commit into from
Dec 7, 2023

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Dec 6, 2023

fixes #1681

  • If the user provided permission the upper part will show the camera otherwise a hint is shown that no permission has been granted to show the camera
  • destination is directly validated on the scanner screen and only forwarded to the send screen if valid.
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-12-06.at.20.09.10.mp4

@holzeis holzeis self-assigned this Dec 6, 2023
luckysori
luckysori approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beyond the message.

mobile/lib/features/wallet/scanner_screen.dart Outdated Show resolved Hide resolved
@holzeis holzeis force-pushed the feat/rework-scanner-screen branch from 22f6178 to 9041424 Compare December 7, 2023 09:37
@holzeis holzeis enabled auto-merge December 7, 2023 09:37
@holzeis holzeis disabled auto-merge December 7, 2023 09:47
@holzeis holzeis force-pushed the feat/rework-scanner-screen branch from 9041424 to ae451e8 Compare December 7, 2023 09:53
@holzeis holzeis enabled auto-merge December 7, 2023 09:54
@holzeis holzeis added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 079fa31 Dec 7, 2023
9 checks passed
@holzeis holzeis deleted the feat/rework-scanner-screen branch December 7, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckysori luckysori luckysori approved these changes

@bonomat bonomat Awaiting requested review from bonomat

@Restioson Restioson Awaiting requested review from Restioson

Assignees

@holzeis holzeis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show scanner when clicking the send button
3 participants
@holzeis @Restioson @luckysori