wip: reproduce timing issue #1740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a position is getting resized we close the current contract and reopen a new one. It might happen that the task will pick it up in the meantime and set the to closed. This breaks the renew protocl because we expect the position to be in a certain state
|
Closing this as it's not meant to be merged |
luckysori
reviewed
Dec 14, 2023
| @@ -98,7 +98,17 @@ impl Node { | |||
| }, | |||
| )?; | |||
|
|
|||
| db::positions::Position::set_open_position_to_resizing(conn, position.trader.to_string())?; | |||
| let pool = self.pool.clone(); | |||
| tokio::spawn({ | |||
There was a problem hiding this comment.
Interestingly, I wasn't able to reproduce it, although I was using std::thread::spawn instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a position is getting resized we close the current contract and reopen a new one. It might happen that the task will pick it up in the meantime and set the to closed. This breaks the renew protocl because we expect the position to be in a certain state/
How to reproduce:
the task
closed_positionwill pick it up and set the position to closed breaking the renew protocol.