fix: race condition on resizing #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonomat
force-pushed
the
fix/accidentally-closing-positions
branch
from
bca9266 to
90c8ac3
Compare
holzeis
approved these changes
Dec 13, 2023
| // this should never happen because we are only loading `Open` and | ||
| // `Resizing` a few lines above | ||
| tracing::error!( | ||
| channel_id = msg.channel_id.to_hex(), |
There was a problem hiding this comment.
🔧 the comment does not match the match statement.
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased] | |||
|
|
|||
| - Feat: Receive USD-P via Lightning | |||
| - Fix: a bug which may lead to a stuck position due to some async tasks | |||
There was a problem hiding this comment.
nit: Instead of writing what it may fix, I would write what has changed. Like replaced a task with explicitly setting the closed state when the protocol finished.
There was a problem hiding this comment.
Maybe we need to agree for whom the changelog is 😅
What you describe can be found in the commit message while here I'm writing high-level description only.
There was a problem hiding this comment.
It would still be high level wouldn't it? 🤔
There was a problem hiding this comment.
Mhm, fair enough. I'll extend it and we all will be happy :D
bonomat
force-pushed
the
fix/accidentally-closing-positions
branch
2 times, most recently
from
a95d52d to
2cbc7bc
Compare
By setting the position only to closed in our db when we receive the `CloseFinalize` event we can get rid of the async task `closed_positions` which checked regularly if a position needs to be closed in the db. This helps us to remove a race condition where a position was accidentally set to closed which was actually in resizing.
bonomat
force-pushed
the
fix/accidentally-closing-positions
branch
from
2cbc7bc to
b38a2a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the position only to closed in our db when we receive the
CloseFinalizeevent we can get rid of the async taskclosed_positionswhich checked regularly if a position needs to be closed in the db. This helps us to remove a race condition where a position was accidentally set to closed which was actually in resizing.Resolves https://github.com/get10101/meta/issues/259
Resolves https://github.com/get10101/meta/issues/262
Replaces #1734