feat: Send and receive on-chain funds #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
holzeis
commented
Jan 20, 2024
•
holzeis
commented
holzeis
force-pushed
the
feat/send-and-receive-on-chain
branch
from
603f382 to
ff429ce
Compare
bonomat
reviewed
Jan 20, 2024
Comment on lines
+46
to
+71
| .unwrap_or(Balance { | ||
| on_chain: 0, | ||
| off_chain: 0, | ||
| }); |
There was a problem hiding this comment.
We should probably return an error to the caller instead of setting it to 0 here. Could be quite scary if the balance shows suddenly 0.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
I suggest we do that when we consider implementing polling or push. Otherwise, the user would simply get an error only because his request came in earlier than the wallet info event has been published.
bonomat
reviewed
Jan 20, 2024
bonomat
approved these changes
Jan 20, 2024
bonomat
reviewed
Jan 20, 2024
Comment on lines
75
to
80
| AmountInputField( | ||
| value: amount != null ? amount! : Amount.zero(), | ||
| label: "Amount in sats", | ||
| controller: _amountController, | ||
| validator: (value) { | ||
| return null; |
There was a problem hiding this comment.
When merged I'll see to make this look the same as the other input fields
holzeis
force-pushed
the
feat/send-and-receive-on-chain
branch
from
ff429ce to
5332482
Compare
holzeis
force-pushed
the
feat/send-and-receive-on-chain
branch
from
5332482 to
8c9e24a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.