Make use of latest quote #1878
Merged
Make use of latest quote #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Hoenisch <[email protected]>
Also use the quote to calculate PnL. Signed-off-by: Philipp Hoenisch <[email protected]>
bonomat
force-pushed
the
feat/orders-in-webapp
branch
from
1f0425d to
61161e6
Compare
holzeis
approved these changes
Jan 23, 2024
| @@ -38,6 +40,7 @@ class _ScaffoldWithNestedNavigation extends State<ScaffoldWithNestedNavigation> | |||
|
|
|||
| String version = "unknown"; | |||
| Balance balance = Balance.zero(); | |||
| BestQuote? bestQuote; | |||
There was a problem hiding this comment.
nit: We should probably start to use change notifiers to keep these states.
| const SizedBox( | ||
| width: 20, | ||
| height: 20, | ||
| child: CircularProgressIndicator(), |
There was a problem hiding this comment.
🤔 It's weird to have a spinner here, since it will never go away unless the user navigates or refreshes the page. But I guess it will help us once we implement websockets.
| final response = await HttpClientManager.instance.get(Uri(path: '/api/quotes/BtcUsd')); | ||
|
|
||
| if (response.statusCode == 200) { | ||
| var quote2 = BestQuote.fromJson(jsonDecode(response.body) as Map<String, dynamic>); |
There was a problem hiding this comment.
❓ why quote2 and not quote 😅
There was a problem hiding this comment.
haha, because of reasons.
| isBuy = widget.isLong; | ||
| _isLoading = false; | ||
| context.read<QuoteService>().fetchQuote().then((q) => setState(() { |
There was a problem hiding this comment.
🔧 This is already third time I am seeing this, I think using a change notifier would really make sense for the quote service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1872