Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Only depend on the certs directory if secure flag is set #1885

Merged

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Jan 24, 2024

It's cumbersome to deal with providing a valid cert path if we don't even want to start securely.

It's cumbersome to deal with providing a valid cert path if we don't even want to start securely.
@holzeis holzeis requested review from bonomat and luckysori January 24, 2024 08:13
@holzeis holzeis self-assigned this Jan 24, 2024
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holzeis holzeis added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 1ab1365 Jan 24, 2024
10 checks passed
@holzeis holzeis deleted the chore/only-depend-on-certs-directory-if-secure-flag-is-set branch January 24, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants