chore: Enforce minimum quantity to 500 on dlc channel open #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
changed the title
At the moment we can be certain that there will ever only be one **signed** dlc channel. A previous channel that has been closed on-chain is not in a signed state and will not be returned by this function. Use `list_dlc_channels` to get also non-signed dlc channels. Note, its not safe to use `first` on the `list_dlc_channels` function.
holzeis
force-pushed
the
chore/enforce-smallest-channel-size
branch
from
eb1f251 to
1648cfe
Compare
luckysori
approved these changes
Jan 25, 2024
bonomat
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/get10101/meta/issues/295