Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flutter versions #2536

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix Flutter versions #2536

merged 1 commit into from
May 14, 2024

Conversation

luckysori
Copy link
Contributor

To avoid random breaking changes showing up in CI.

AFAIK these were the versions we were using before stable was updated.

@luckysori
chore: Fix Flutter versions
6fd4d70 
To avoid random breaking changes showing up in CI.
@luckysori luckysori requested review from bonomat and holzeis May 14, 2024 06:14
@luckysori luckysori self-assigned this May 14, 2024
@luckysori luckysori enabled auto-merge May 14, 2024 09:21
bonomat
bonomat requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check if the "3.22.0" has the needed fix for us.

bonomat
bonomat approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@bonomat bonomat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works. Meaning we do not need beta-channel anymore. I'm happy to remove fvm again if you guys want?

@luckysori / @holzeis ?

@luckysori luckysori added this pull request to the merge queue May 14, 2024
@luckysori
Copy link
Contributor Author

Nice, works. Meaning we do not need beta-channel anymore. I'm happy to remove fvm again if you guys want?

@luckysori / @holzeis ?

Hmm, I don't mind FVM. I like the fact that I was able to use the .fvmrc to set a specific version.

@holzeis
Copy link
Contributor

holzeis commented May 14, 2024

Nice, works. Meaning we do not need beta-channel anymore. I'm happy to remove fvm again if you guys want?

@luckysori / @holzeis ?

I would like to get rid of it if we don't need it. One less tooling on our stack.

@bonomat I guess it also means we can use the same flutter version for web app and app?

Merged via the queue into main with commit b1881bd May 14, 2024
23 checks passed
@luckysori luckysori deleted the chore/fix-flutter-versions branch May 14, 2024 10:31
@luckysori
Copy link
Contributor Author

Nice, works. Meaning we do not need beta-channel anymore. I'm happy to remove fvm again if you guys want?

@luckysori / @holzeis ?

I would like to get rid of it if we don't need it. One less tooling on our stack.

@bonomat I guess it also means we can use the same flutter version for web app and app?

We need to fix the versions for CI though.

This PR did not change the versions btw. I just changed the target from a moving target to a fixed target. Because a PR was failing after stable was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonomat bonomat bonomat approved these changes

@holzeis holzeis Awaiting requested review from holzeis

Assignees

@luckysori luckysori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luckysori @holzeis @bonomat