Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent multiple next button clicks #2572

Merged
merged 1 commit into from
May 29, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented May 28, 2024

The lnd node is running separately on the test vm, which can lead to a delay when requesting a new invoice.

This patch disables the button and indicates to the user that the request is being processed.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-28.at.14.30.15.mp4

@holzeis holzeis requested review from bonomat and luckysori May 28, 2024 12:33
@holzeis holzeis self-assigned this May 28, 2024
@holzeis holzeis force-pushed the fix/prevent-multiple-next-clicks branch 2 times, most recently from 883723a to 0952dfa Compare May 28, 2024 12:33
The lnd node is running separately on the test vm, which can lead to a delay when requesting a new invoice.

This patch disables the button and indicates to the user that the request is being processed.
@holzeis holzeis force-pushed the fix/prevent-multiple-next-clicks branch from 0952dfa to d17a174 Compare May 28, 2024 13:01
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@holzeis holzeis added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 33ab37a May 29, 2024
23 checks passed
@holzeis holzeis deleted the fix/prevent-multiple-next-clicks branch May 29, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants