fix: only publish and wait till eos if unpublished #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am wondering if we should not do the EOS at all and check manually the event age. but as far as I understand the PR it makes sense. |
chore: remove all mutexes and store in subscription struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscription is stopped after the request event publish go routine starts (which may or may not have published it, there is high chance that some are published and then the subscription got stopped...
And once we reconnect we wait till EOS, so the response event is lost by then, I think we should only wait for EOS if the request event is not yet published, so if reconnection happens and the event is already published we do not wait for EOS and go through the stored ones to find.