chore: remove all mutexes and store in subscription struct #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
force-pushed
the
task-mutexes
branch
from
37d948f to
192ad37
Compare
rolznz
reviewed
Dec 20, 2024
|
|
||
| if (!exists && !subscription.Open) { | ||
| if (!subscription.Open) { |
There was a problem hiding this comment.
just curious, why is this check not at the start of the method?
There was a problem hiding this comment.
is it because it only applies for .e.g subscribing to notifications?
|
|
rolznz
reviewed
Dec 20, 2024
| @@ -804,7 +792,7 @@ func (svc *Service) publishRequestEvent(ctx context.Context, subscription *Subsc | |||
| "client_pubkey": clientPubkey, | |||
| }).Error("Failed to publish to relay") | |||
| subscription.RequestEvent.State = REQUEST_EVENT_PUBLISH_FAILED | |||
| sub.Unsub() | |||
| relaySubscription.Unsub() | |||
There was a problem hiding this comment.
should stopSubscription be called here? or not?
There was a problem hiding this comment.
Did that because it's directly available, but good to keep it consistent 👍 will change to stopSubscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need of mutexes as the suibscription struct is carried everywhere, so it's best to add the
relaySubscriptionto the subscription itself instead of adding those tosvc.subscriptions