Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conflict warning is not removed on switching #1054

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix: conflict warning is not removed on switching #1054

merged 1 commit into from
Jan 31, 2025

Conversation

im-adithya
Copy link
Member

Fixes #1053

@im-adithya im-adithya requested a review from rolznz January 31, 2025 11:10
rolznz
rolznz approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@im-adithya
Copy link
Member Author

im-adithya commented Jan 31, 2025 •
edited
Loading

Don't merge this, have to check it once

Edit: whoops false alarm, I thought Mutinynet Olympus also only allows Private only channels but it allows both, this PR is good to go!

@rolznz rolznz merged commit 8363a47 into master Jan 31, 2025
10 checks passed
@rolznz rolznz deleted the task-fix-privpub branch January 31, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public channel checkbox is not unchecked on switching to a partner which only offers private channels
2 participants
@im-adithya @rolznz