feat: use user agent for requests from auth object #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Nov 6, 2023
| @@ -52,6 +52,11 @@ export async function request({ | |||
| const authHeader = auth | |||
| ? await auth.getAuthHeader(url.href, method) | |||
| : undefined; | |||
|
|
|||
| let userAgent; | |||
| if(auth?.getUserAgent) | |||
There was a problem hiding this comment.
this is not needed
this.defaultRequestOptions from the Client class is passed to rest which is passed to this request method.
You don't need to add a function getUserAgent.
Can you please undo the change, test this locally and make sure the user agent is being passed in every request, and if not, why?
|
closing it as we now decided to use user-agent passed in default request options object and not auth object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.