feat: add decode invoice function #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
commented
Nov 14, 2023
bumi
reviewed
Nov 15, 2023
| @@ -2,3 +2,4 @@ export * as auth from "./auth"; | |||
| export * as types from "./types"; | |||
| export * as webln from "./webln"; | |||
| export { Client } from "./client"; | |||
| export * from "./decodeInvoice"; | |||
There was a problem hiding this comment.
hmmm, I don't think this is a nice API.
Just exposing the global function because that people don't have to import it from the light-bolt11-decoder.
doesn't this make more sense to have in the Invoice https://github.com/getAlby/js-lightning-tools/blob/master/src/invoice.ts
So I can initialize an invoice and then have all the data available there?
There was a problem hiding this comment.
@bumi sounds good to me. Would it make sense for this sdk to depend on lightning-tools? or should people install both packages as they are doing now? I think it would be nice to have some support for decoding invoices in this library?
There was a problem hiding this comment.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #127
adds only one dependency