feat: add nip 44 and versioning support #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Nov 30, 2024
rolznz
reviewed
Nov 30, 2024
@im-adithya this is great! 🚀 please let me know when it's ready for testing. |
im-adithya
commented
Dec 3, 2024
|
Done, ready for testing! |
|
EDIT, wrong repository. See getAlby/hub#834 (comment) |
rolznz
reviewed
Jan 3, 2025
rolznz
reviewed
Jan 9, 2025
rolznz
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review
nostr-toolsv2 as nip44 library doesn't match the latest spec (and hence gives errors as it doesn't match with the Hub's nip-44)nip-44folder so we can test it, in the meantime I'll work on a PR to shift tonostr-toolsv2 so we can remove it.