feat: add nip-05 #15
Open
feat: add nip-05 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a "must", because of #7? Currently this is optional |
Yes, I think so |
rolznz
reviewed
Dec 17, 2024
| @@ -4,6 +4,7 @@ export const users = pgTable("users", { | |||
| id: serial("id").primaryKey(), | |||
| encryptedConnectionSecret: text("connection_secret").notNull(), | |||
| username: text("username").unique().notNull(), | |||
| nostrPubkey: text("nostr_pubkey").unique(), | |||
There was a problem hiding this comment.
I don't think this should be unique. It's a contact pubkey, and one person could create two or more lightning addresses
There was a problem hiding this comment.
In getalby.com you see this error message if you use an existing pubkey:
There was a problem hiding this comment.
@bumi do you have any thoughts here?
There was a problem hiding this comment.
we make it not unique, it's not really protecting anything as discussed.
rolznz
reviewed
Dec 17, 2024
im-adithya
commented
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Also fixes the create users endpoint which returns server error when something goes wrong (no secret, same username and now same nostr pubkey etc)