Merge pull request #11 from getappmap/feat/log-kill-warning

feat: Log command string when killed by a signal
getappmap · May 15, 2023 · 46c4eff · 46c4eff
2 parents b249571 + 87f7442
commit 46c4eff
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/Compare.ts b/src/Compare.ts
@@ -22,7 +22,7 @@ export default class Compare {
 
     log(
       LogLevel.Info,
-      `Comparing base revision ${this.baseRevision} to head revision ${this.headRevision}`
+      `Comparing base revision ${this.baseRevision} with head revision ${this.headRevision}`
     );
     log(LogLevel.Debug, `Report output directory is ${outputDir}`);
 

diff --git a/src/executeCommand.ts b/src/executeCommand.ts
@@ -40,10 +40,14 @@ export function executeCommand(
   return new Promise<string>((resolve, reject) => {
     command.addListener('exit', (code, signal) => {
       if (signal || code === 0) {
-        if (signal) log(LogLevel.Info, `Command killed by signal ${signal}`);
+        if (signal)
+          log(
+            LogLevel.Warn,
+            `Command "${commandString}" killed by signal ${signal}, exited with code ${code}`
+          );
         resolve(result.join(''));
       } else {
-        if (!printCommand) log(LogLevel.Warn, commandString);
+        log(LogLevel.Warn, `Command "${commandString}" exited with failure code ${code}`);
         log(LogLevel.Warn, stderr.join(''));
         log(LogLevel.Warn, result.join(''));