fixup! fix: Use git attributes to identify binary files

getappmap · Oct 24, 2024 · ec4f9d8 · ec4f9d8
1 parent 190762d
commit ec4f9d8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/cli/src/fulltext/FileIndex.ts b/packages/cli/src/fulltext/FileIndex.ts
@@ -259,11 +259,9 @@ const DATA_FILE_EXTENSIONS: string[] = [
   'xml',
 ].map((ext) => '.' + ext);
 
-const isBinaryFile = (fileName: string, gitAttributes?: ReturnType<typeof getGitAttributes>) => {
-  if (BINARY_FILE_EXTENSIONS.some((ext) => fileName.endsWith(ext))) return true;
-  if (gitAttributes?.some((attr) => attr.binary && minimatch(fileName, attr.pattern))) return true;
-  return false;
-};
+const isBinaryFile = (fileName: string, gitAttributes?: ReturnType<typeof getGitAttributes>) =>
+  BINARY_FILE_EXTENSIONS.some((ext) => fileName.endsWith(ext)) ||
+  gitAttributes?.some((attr) => attr.binary && minimatch(fileName, attr.pattern, { dot: true }));
 
 const isDataFile = (fileName: string) => {
   return DATA_FILE_EXTENSIONS.some((ext) => fileName.endsWith(ext));

diff --git a/packages/cli/tests/unit/fulltext/FileIndex.spec.ts b/packages/cli/tests/unit/fulltext/FileIndex.spec.ts
@@ -190,6 +190,7 @@ describe(filterFiles, () => {
     writeFileSync(join(dir, 'file.txt'), 'hello');
     writeFileSync(join(dir, 'file.my-extension'), 'hello');
     writeFileSync(join(dir, 'file.bin'), 'hello');
+    writeFileSync(join(dir, '.file.bin'), 'hello');
 
     const fileList = readdirSync(dir);
     const gitAttributes = getGitAttributes(dir);