-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust Mermaid diagram fixing #2084
Conversation
This displays a message to the user on fix attempt and avoids DOMPurify errors.
451a1bc
to
cf49330
Compare
@@ -45,6 +45,7 @@ | |||
"@langchain/openai": "^0.2.7", | |||
"fast-xml-parser": "^4.4.0", | |||
"js-yaml": "^4.1.0", | |||
"jsdom": "^16.6.0", | |||
"langchain": "^0.2.16", | |||
"mermaid": "^9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you're here, can you take a look at upgrading to mermaid 10? I believe that would allow vscode-appland to link to a local appmap-js repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually did try, but mermaid 10 is ESM-only.
cf49330
to
a07b35c
Compare
🎉 This PR is included in version @appland/navie-v1.34.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This improves mermaid diagram fixing in the backend by: