Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual adjustments to signup form #2087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Daniel-Warner-X
Copy link
Contributor

@Daniel-Warner-X Daniel-Warner-X commented Oct 23, 2024

This is part of the Get New Users Into Chat epic. Along with updates to the UI of adjacent components, this contributes to conveying a sense of organization and stability to new users. It also aims to drive more email activations but being clearer about how lightweight that process is.

Updates the button label on email signup, the visual design of the 'your data is your data' message, and the responsive behavior of the form at large sizes.

New View:

image image

Existing View:

image

image

@dustinbyrne dustinbyrne self-requested a review October 28, 2024 13:48
@@ -384,7 +388,6 @@ export default {
.your-data {
display: flex;
flex-direction: row;
align-items: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the "your data is your data" messaging collapses into rows, the shield is no longer aligned with this change
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a @media (max-width: 365px) query responsible for this somewhere.

@@ -396,6 +399,10 @@ export default {
max-width: 33px;
height: 42px;
}

.your-data-text {
font-size: 0.85rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that rem units tend to be larger once in VS Code. You may want to consider using em here. Here's what it currently looks like in VS Code:
image

@@ -250,6 +250,10 @@ export default {
padding: 1.5rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks unrelated to this particular change, but I'm noticing that the height: 100% on .signin-sidebar will cause text to overflow the container if the view is too narrow.
image

@dustinbyrne
Copy link
Contributor

dustinbyrne commented Oct 30, 2024

This test will need to be updated

cy.get('[data-cy="email-activation-button"]')
.should('contain.text', 'Activate with')
.should('contain.text', 'Email');

Activate with just needs to change to Get activation code by. Or just remove the calls to should - I don't find it necessary to assert the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants