-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual adjustments to signup form #2087
base: main
Are you sure you want to change the base?
Conversation
@@ -384,7 +388,6 @@ export default { | |||
.your-data { | |||
display: flex; | |||
flex-direction: row; | |||
align-items: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a @media (max-width: 365px)
query responsible for this somewhere.
@@ -396,6 +399,10 @@ export default { | |||
max-width: 33px; | |||
height: 42px; | |||
} | |||
|
|||
.your-data-text { | |||
font-size: 0.85rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -250,6 +250,10 @@ export default { | |||
padding: 1.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will need to be updated appmap-js/packages/components/tests/e2e/specs/sidebarSignIn.spec.js Lines 21 to 23 in d764365
|
This is part of the Get New Users Into Chat epic. Along with updates to the UI of adjacent components, this contributes to conveying a sense of organization and stability to new users. It also aims to drive more email activations but being clearer about how lightweight that process is.
Updates the button label on email signup, the visual design of the 'your data is your data' message, and the responsive behavior of the form at large sizes.
New View:
Existing View: