Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust the first line of a patch when it has 0 indent #2097

Closed
wants to merge 2 commits into from

Conversation

kgilpin
Copy link
Contributor

@kgilpin kgilpin commented Oct 28, 2024

Fixes #2095

@kgilpin kgilpin requested a review from dividedmind October 28, 2024 21:25
@kgilpin kgilpin self-assigned this Oct 28, 2024
@kgilpin kgilpin added the enhancement New feature or request label Oct 28, 2024
@dividedmind
Copy link
Collaborator

dividedmind commented Oct 29, 2024

I don't think this actually works... let me double check. I had a simpler solution in mind, if this doesn't work then I'll try mine, ok? (Especially seeing you went ahead and worked on it even though I grabbed it ;P)

@kgilpin
Copy link
Contributor Author

kgilpin commented Oct 29, 2024

Yeah, it doesn't. Try your way.

@dividedmind
Copy link
Collaborator

dividedmind commented Oct 29, 2024

Yeah, it doesn't. Try your way.

I will. For now I pushed a commit here that makes the tests more robust so it's apparent that it doesn't work.

@dividedmind
Copy link
Collaborator

Another approach at #2100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLM output mis-indents the first line of the patch
2 participants