fix: Review now includes code selections #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dividedmind
approved these changes
Dec 2, 2024
Comment on lines
214
to
218
| pinnedItems.filter(UserContext.isCodeSelectionItem).forEach((cs) => | ||
| pinnedItemLookup.push({ | ||
| type: ContextV2.ContextItemType.CodeSelection, | ||
| content: cs.content, | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Small nitpick — forEach is great for when you already have a named function to iterate with, but with a lambda like that for ... of is IMO much more readable (not to mention about 20× faster). Or do something like this:
Suggested change
| pinnedItems.filter(UserContext.isCodeSelectionItem).forEach((cs) => | |
| pinnedItemLookup.push({ | |
| type: ContextV2.ContextItemType.CodeSelection, | |
| content: cs.content, | |
| }) | |
| ); | |
| pinnedItemLookup.push( | |
| ...pinnedItems | |
| .filter(UserContext.isCodeSelectionItem) | |
| .map((cs) => ({ ...cs, type: ContextV2.ContextItemType.CodeSelection })) | |
| ); |
There was a problem hiding this comment.
(BTW, it's weird that we have to retype type like that even though the value is the same. ContextV2.ContextItemType should really have been a union type, not an enum.)
The JetBrains is still sending pinned items as 'code selections', instead of located files. This means that in IntelliJ, pinned items would not be considered during `@review`.
dustinbyrne
force-pushed
the
fix/review-code-selections
branch
from
1a0c820 to
9dc6ee7
Compare
|
🎉 This PR is included in version @appland/navie-v1.38.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
JetBrains IDEs (IntelliJ, etc.) were sending pinned items as 'code selections' without location information, causing them to be ignored during the
@reviewcommand. This resulted in incomplete context being considered during code reviews in JetBrains environments.Solution
Modified the
getPinnedItemsfunction to include code selections that don't have location information. This maintains backward compatibility while ensuring that pinned items in JetBrains IDEs are properly included in the review context.Changes
Testing
Review Summary
The changes have been reviewed and approved across multiple domains:
These changes improve the integration with JetBrains IDEs without disrupting existing functionality in other environments.