Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Skip OpenAPI on test failure #18

Closed
wants to merge 3 commits into from
Closed

feat: Skip OpenAPI on test failure #18

wants to merge 3 commits into from

Conversation

kgilpin
Copy link
Contributor

@kgilpin kgilpin commented Aug 17, 2023 •
edited
Loading

If there is a failed test, don't bother generating OpenAPI.

@kgilpin
feat: Skip OpenAPI on test failure
cae6a62 
If there is a failed test, don't bother generating OpenAPI.
@kgilpin
ci: Use main branch of AppMap actions
8e52746
@kgilpin kgilpin marked this pull request as ready for review August 17, 2023 17:45
@github-actions
Copy link
Contributor

AppMap

Summary Status
Test failures ✅ All tests passed
API changes ✅ No API changes
Findings ✅ None
New AppMaps ⭐ 1 new
Changed code behavior ✅ No changes

New AppMaps

jest/merge when a test has failed skips OpenAPI generation

@kgilpin kgilpin closed this Aug 18, 2023
@kgilpin kgilpin deleted the feat/skip-openapi-on-test-failure branch August 18, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kgilpin