feat: add ditto operator support #19
Conversation
|
|
Merge contigent upon:
|
| {{- /* Generate big peer deployment config driven by ditto operator */ -}} | ||
| {{- $fullname := include "common.names.fullname" . -}} | ||
| {{- $values := index .Values "ditto-deployment" -}} | ||
| {{- $storageClassName := default "local-path" $values.storage.storage_class_name -}} |
There was a problem hiding this comment.
StorageClass should be left blank by default, so that the cluster default is used.
local-path will not be compatible with most clusters.
There was a problem hiding this comment.
Good point, will make sure this one is addressed.
| imagePullPolicy: {{ $values.image.pullPolicy }} | ||
| imagePullSecrets: [] | ||
| resources: | ||
| limits: |
There was a problem hiding this comment.
Could we expose these resource settings as values instead of hardcoding.
There was a problem hiding this comment.
Yep, was hardcoded just to get it working. This is a draft currently..
| imagePullSecrets: [] | ||
| resources: | ||
| limits: | ||
| cpu: 2000m |
| # Additional ingresses can be added by adding a dictionary key similar to the 'main' ingress. | ||
| # @default -- See below | ||
| ingress: | ||
| main: |
There was a problem hiding this comment.
Why is this being removed? Is this incompatible with Ditto Operator?
We are relying on this for valet.
There was a problem hiding this comment.
Hey, just seeing the feedback here. Yeah this branch is just for tracking what "works", not an optimized push for merge.
Currently Ditto Operator defines an ingress with nginx ingress class. This is wholly decoupled from the helm chart ingress route. What I have been doing is just ignoring the ingress config provided by the operator & relying on this one here. By removing the block Im making it "non default", but downstream I still specify it if that makes sense.
charts/big-peer/Chart.lock
Outdated
| - name: hydra-consul | ||
| repository: oci://quay.io/ditto-external | ||
| - name: ditto-operator | ||
| repository: file://../../../ditto/charts/operator |
There was a problem hiding this comment.
We should update this to a public source.
charts/big-peer/Chart.yaml
Outdated
| repository: "oci://quay.io/ditto-external" | ||
| condition: hydra-subscription.enabled | ||
| #repository: "oci://quay.io/ditto-external" | ||
| repository: "file://../../../ditto/charts/operator" |
There was a problem hiding this comment.
Yeah these were pinned to local because at the time the branch was made it was only in a branch on the monorepo. These will be cleaned up before marking off draft :)
adds support for ditto operator, moving away from
hadesas we look towards its deprecation