Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of special links #1354

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Improve handling of special links #1354

merged 2 commits into from
Jan 5, 2025

Conversation

markdumay
Copy link
Collaborator

Treats links that have a scheme other than http or https as special case.

Treats links that have a scheme other than http or https as special case.
@markdumay markdumay added the bug Something isn't working label Jan 5, 2025
Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for gethinode-demo ready!

Name Link
🔨 Latest commit 1da69c0
🔍 Latest deploy log https://app.netlify.com/sites/gethinode-demo/deploys/677a82abfb02be0008d4623c
😎 Deploy Preview https://deploy-preview-1354--gethinode-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for gethinode-demo ready!

Name Link
🔨 Latest commit 7c436dc
🔍 Latest deploy log https://app.netlify.com/sites/gethinode-demo/deploys/677a82b1055fc50008d2e18f
😎 Deploy Preview https://deploy-preview-1354--gethinode-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@markdumay markdumay merged commit 7d724db into main Jan 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant