added flashlight-tester, to be used by pinger #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflog
force-pushed
the
reflog/tester
branch
2 times, most recently
from
099d385 to
e2b4cc1
Compare
WendelHime
reviewed
Dec 11, 2024
reflog
force-pushed
the
reflog/tester
branch
from
a215ebc to
8537edb
Compare
hwh33
approved these changes
Dec 13, 2024
tester/README.md
Outdated
| - `TOKEN`: The token to use. | ||
| - `RUN_ID`: The run id to use. It will be added to honeycomb traces as value of attribute `pinger-id`. (you can use it for looking up traces for the specific run) | ||
| - `TARGET_URL`: The target url to use. This is the url that will be pinged through flashlight. | ||
| - `OUTPUT`: The output path to use. This is the path where the output will be written to (proxies.yaml, global.yaml, etc). You can place proxies.yaml there to use it instead of fetching. |
There was a problem hiding this comment.
There's a lot of language in here about the "output directory" which in reality appears to be the config directory. Why not just call it the config directory? That's what the team is used to calling that folder. Given that it holds config, it's also more of an input directory which adds some confusion to the new lingo IMO.
There was a problem hiding this comment.
I see that you are writing output files to the config directory. You could either (a) define a new directory for that, accepting both an OUTPUT_DIR and CONFIG_DIR (which could be the same) or (b) just state that the program will write output files to the config directory.
reflog
force-pushed
the
reflog/tester
branch
from
8537edb to
9839f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please see tester/README.md for details