reduced the number of init() calls and references to staging #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WendelHime
reviewed
Jan 28, 2025
common/const.go
Outdated
| } | ||
| forceAds, _ = strconv.ParseBool(os.Getenv("FORCEADS")) | ||
| } | ||
| var forceAds, _ = strconv.ParseBool(os.Getenv("FORCEADS")) |
There was a problem hiding this comment.
I guess this can also be removed with the function below, I don't see any reference or usage (it looks like the same file exists in lantern-client internalsdk/common/const.go and also is not being used)
There was a problem hiding this comment.
probably this whole package shouldn't exist, this definitions are only used at specific packages and most stuff is unused
There was a problem hiding this comment.
Agreed forceads can go
WendelHime
approved these changes
Jan 28, 2025
reflog
force-pushed
the
reflog/late-init
branch
from
32b6591 to
090a964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly the reason for this cleanup is - our over-use of init() function causes extra logs to leak out before Flashlight is actually initialized
oh, and I removed references to Staging, since... it doesn't exist.