create cache directory if it doesn't exist #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garmr-ulfr
commented
Dec 17, 2024
Comment on lines
-18
to
-19
| // This is not a big deal since we'll just fill the cache later | ||
| log.Debugf("ignorable error: Unable to read cache file for prepopulation: %v", err) |
There was a problem hiding this comment.
I don't think this is ignorable. By this point if it can't read the file it won't be able to write to it later.
There was a problem hiding this comment.
This isn't really true, as it just means no cache file has been created yet. That will be true every time on the first run, for example.
There was a problem hiding this comment.
By this point if it can't read the file it won't be able to write to it later.
Sorry, by this I meant after including the change to create the parent directory.
However, even before this, while unlikely, it could still fail if it doesn't have read/write permissions on the directory.
|
@garmr-ulfr Changes are working for me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces this PR.