Test tcp #12
Open
Test tcp #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,11 @@ func (p *peer) answer(wm *waddell.MessageIn) { | |||
| } | |||
|
|
|||
| log.Printf("Got five tuple: %s", ft) | |||
| go readUDP(p.id, traversalId, ft) | |||
| if ft.Proto == "tcp" { | |||
There was a problem hiding this comment.
Check indentation. Also, please run gofmt on this.
|
@ed2k Have you found a situation in which natty returns a TCP 5-tuple? |
|
@ed2k Did a little digging, looks like it's theoretically possible to get a TCP 5-tuple. |
| @@ -107,11 +111,38 @@ func readUDP(peerId waddell.PeerId, traversalId uint32, ft *natty.FiveTuple) { | |||
| if err != nil { | |||
| log.Fatalf("Unable to read from UDP: %s", err) | |||
| } | |||
| msg := string(b[:n]) | |||
| log.Printf("Got UDP message from %s: '%s'", addr, msg) | |||
| msg := hex.Dump(b[:n]) | |||
There was a problem hiding this comment.
Why this change? The message being sent is a UTF-8 string, why hex encode it?
There was a problem hiding this comment.
I saw case that it affected the terminal display.
|
@ed2k Thanks for submitting this! Please see my comments inline with the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.