fix: updating the way we're comparing hashes

getlantern · Oct 9, 2024 · 88f63ee · 88f63ee
1 parent b2fee93
commit 88f63ee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/water/downloader.go b/water/downloader.go
@@ -111,7 +111,7 @@ var ErrFailedToVerifyHashSum = errors.New("failed to verify hash sum")
 
 func (d *downloader) verifyHashSum(data []byte) error {
 	sha256Hashsum := sha256.Sum256(data)
-	if d.expectedHashSum == "" || !bytes.Equal(sha256Hashsum[:], []byte(d.expectedHashSum)) {
+	if d.expectedHashSum == "" || d.expectedHashSum != fmt.Sprintf("%x", sha256Hashsum[:]) {
 		return ErrFailedToVerifyHashSum
 	}
 	return nil

diff --git a/water/downloader_test.go b/water/downloader_test.go
@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"crypto/sha256"
+	"fmt"
 	"io"
 	"net/http"
 	"testing"
@@ -73,7 +74,7 @@ func TestDownloadWASM(t *testing.T) {
 
 	contentMessage := "content"
 	hashsum := sha256.Sum256([]byte(contentMessage))
-	contentHashsum := string(hashsum[:])
+	contentHashsum := fmt.Sprintf("%x", hashsum[:])
 	var tests = []struct {
 		name                 string
 		givenHTTPClient      *http.Client